Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Bug] Multiple different endpoints are using the same value for operationID GHES 3.12, GHES 3.13 #3720

Open
wolfy1339 opened this issue Jul 5, 2024 · 3 comments

Comments

@wolfy1339
Copy link

wolfy1339 commented Jul 5, 2024

Schema Inaccuracy

Multiple different endpoints are using the same value for operationID of enterprise-admin/get-manage-settings

  • GET /manage/v1/config/apply/events
  • GET /manage/v1/config/settings
  • GET /manage/v1/config/apply
  • POST /manage/v1/config/apply

Expected

Each endpoint has it's own uniuqe operationID
The the OpenAPI specs be free of bugs like this one that prevents it's usage

Reproduction Steps

N/A as it concerns the schema definitions and not actual response data

Suggested solution

I would like to suggest that the OpenAPI specs be passed through a linter of the likes of Redocly before publishing to minimize any bugs like this

See octokit/openapi-types.ts#429 (comment)

@shiftkey
Copy link
Member

shiftkey commented Jul 5, 2024

@wolfy1339 thanks for the heads up - I've reached out to the team who created these operations, shouldn't be too hard to fix.

@Just091
Copy link

Just091 commented Aug 31, 2024

Bcp14

@Just091
Copy link

Just091 commented Aug 31, 2024

BCP14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants