Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate column for Notes (already coded) #11413

Open
pmgiant opened this issue Nov 30, 2023 · 1 comment · May be fixed by #11417
Open

Separate column for Notes (already coded) #11413

pmgiant opened this issue Nov 30, 2023 · 1 comment · May be fixed by #11417
Labels
🚧 status: in progress Issues which have associated PRs type: feature request

Comments

@pmgiant
Copy link
Contributor

pmgiant commented Nov 30, 2023 •
edited

Feature description

I need to see git notes in a separate column of RevisionGridControl. My notes are usually short and often re-generated by scripts.
I`ve just prepared the required code changes, this issue is for discussion.

The only initially visible change is a new menu item: View / Show git notes column.
Checking it adds a new column to the revision grid, between "Message" and "Avatar".
This column displays the first row of a note.
Notes displayed by CommitDataBodyRenderer (Commit tab of the "Commit info" pane) and MessageColumnProvider remain unaffected.

I`ve simplified the code a bit, now the CommitData and GitRevision classes have separate members for "Body" and "Notes". Parsing/re-formatting logic has been adjusted accordingly, code duplicates were not fixed in order to minimise footprint.
This change probably also fixes some potential bugs, as the notes are no longer part of the content of the message body internally.

Future plans:

  • in-grid editor for short notes,
  • notes refs other than the default one, possibly many.

Environment

  • GitExtensions version: 4.2.1, 65f6637 2023-11-12
  • GIT version: 2.41.0
  • OS version: Win10
  • .NET version: 8.0

Related: #6039 Git notes improvements
@pmgiant pmgiant changed the title Separate column for Notes Separate column for Notes (already coded) Nov 30, 2023
@gerhardol
Copy link
Member

You can as well open the PR for discussion, it is easier to give comments then.

The current "merging" of message/notes is partly historic, partly to not "use resources" for a feature not much used (it has potential though).

@pmgiant pmgiant linked a pull request Nov 30, 2023 that will close this issue
Open
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚧 status: in progress Issues which have associated PRs type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Notes column. pmgiant/gitextensions
2 participants
@gerhardol @pmgiant