Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alter texteditor #8769

Closed
Pavia00 opened this issue Jan 18, 2021 · 10 comments · Fixed by #11239 · May be fixed by #11183
Closed

Add alter texteditor #8769

Pavia00 opened this issue Jan 18, 2021 · 10 comments · Fixed by #11239 · May be fixed by #11183
Labels
🚧 status: in progress Issues which have associated PRs type: feature request up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/

Comments

@Pavia00
Copy link

Pavia00 commented Jan 18, 2021

I want use Notepad++ to edit text. I dream that I have the function of opening a notepad by pressing the F4 key or the context menu. Please add new features in the next implementation.
I think GE can open the editor using git settings.

@gerhardol
Copy link
Member

gerhardol commented Jan 18, 2021

Already there
Settings - Git - Config - Editor

Note: The original question was about Git editor, then it was changed to the GE specific editor

@Pavia00
Copy link
Author

Pavia00 commented Jan 18, 2021

Already there
Settings - Git - Config - Editor

Don't work. Open GT Editor rather of Notepad++

GIF-18-01-2021-12-26-52.gif

@RussKie RussKie reopened this Jan 18, 2021
@RussKie
Copy link
Member

RussKie commented Jan 18, 2021

You're welcome to send a PR.

@RussKie RussKie added type: feature request up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels Jan 18, 2021
@pmiossec
Copy link
Member

pmiossec commented Jan 18, 2021

@Pavia00 There is a misunderstanding...

You set notepad++ as the default editor for Git. So when git want to interact with you (during rebase, ...) it will open Notepad++.

Here the "Edit file in working directory" is a GitExtension feature and it always open the GitExtensions editor.

If you want to open the file with something else, that's a new feature that should be developed...
But we can't reuse the git setting because it contains special parameters to be used by Git only.

So if it's what you want, please could you rewrite your feature request to be more explicit?

@Pavia00
Copy link
Author

Pavia00 commented Jan 18, 2021

Ok. I dream that I have the function of opening a notepad by pressing the F4 key or the context menu. Please add new features in the next implementation.
I think GE can open the editor using git settings, to anymore.

@pmiossec
Copy link
Member

You have Ctrl+O to choose the editor:

image

@Pavia00
Copy link
Author

Pavia00 commented Jan 18, 2021

You have Ctrl+O to choose the editor:
The function open only associated file and don't use git settings as you can see:

GIF-18-01-2021-13-34-53.gif

I can't open dockefiler, Yml .gitignory and all othe service files, becose cannot associating it

For short and fast edit, a file i be wont have open in git editor.

P.S. I never understood. Why so many questions? If you need to correct or add 1 line in the source code.

@RussKie
Copy link
Member

RussKie commented Jan 18, 2021

P.S. I never understood. Why so many questions? If you need to correct or add 1 line in the source code.

If you think it is easy - send a PR. Else - just stop, it won't take us far.

@Pavia00
Copy link
Author

Pavia00 commented Jan 18, 2021

If you think it is easy - send a PR. Else - just stop, it won't take us far.

I can't understand you. Please explain the statement " send a PR. "?

@pmiossec
Copy link
Member

P.S. I never understood. Why so many questions? If you need to correct or add 1 line in the source code.

Once again, you seems to not understand the real behavior and that it is GitExtensions that asks all these questions but that is the Windows way to do.

I can't understand you. Please explain the statement " send a PR. "?

It's difficult for us contributors that knows that things are often not easy to fix because you always have edge cases to handle that something is easy to fix because "you just have to do...". And also having to discuss a lot and explain all that to someone landing on the project.

So, that's Why @RussKie is asking you, if you think it is just a one line fix to do it and create the pull request (PR) so that we just have to review and merge it.

Discussing on such feature requests without code changes is a waste of time for everyone...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 status: in progress Issues which have associated PRs type: feature request up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/
Projects
None yet
4 participants