Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Translations and commentaries are missing dashes #6

Open
samanyougarg opened this issue Dec 24, 2021 · 10 comments
Open

[BUG] Translations and commentaries are missing dashes #6

samanyougarg opened this issue Dec 24, 2021 · 10 comments
Assignees

Comments

@samanyougarg
Copy link
Member

🙁 Actual behavior

Dhrtarastra said O Sanjaya, what did my sons (and others) and Pandu's sons (and others) actually do when, eager for battle, they assembled on the sacred field, the Kuruksetra (Field of the Kurus)?

🙂 Expected behavior

Special symbols like dashes are missing from the translations and commentaries.

For example, all the translations are supposed to have double dashes like below:

Dhrtarastra said -- O Sanjaya, what did my sons (and others) and Pandu's sons (and others) actually do when, eager for battle, they assembled on the sacred field, the Kuruksetra (Field of the Kurus)?

🔢 Steps to Reproduce the Problem

No response

@Gupta-Anubhav12 Gupta-Anubhav12 self-assigned this Dec 24, 2021
@Gupta-Anubhav12 Gupta-Anubhav12 linked a pull request Dec 30, 2021 that will close this issue
@ajjayymahato
Copy link

Is this issue still open? If yes can you assign this issue to me?

@devkapilbansal
Copy link

devkapilbansal commented Oct 2, 2022

Hi @Gupta-Anubhav12 I will work on this issue

@Gupta-Anubhav12
Copy link
Member

Sure thanks
Please feel free to discuss and work on this, I'm assigning to @devkapilbansal for now

@Gupta-Anubhav12
Copy link
Member

it was already kind of done with this
the issue is we need the verse reference for each verse in it's translation, for example we've
verse 1.1
it should be like

we need to add 1.1 for the search to work, right now we've a full text search in backend and it would pick the verse reference from this 1.1 on searching numerically

@devkapilbansal
Copy link

Hi @Gupta-Anubhav12 as per issue description, translations miss dashes for dialog.
Also, what does verse reference means?
I can see a blank line only in your reference

@Gupta-Anubhav12
Copy link
Member

Yes, so we already had a WIP branch that I mentioned above
and now we need the numerical reference to each verse added there
like we've a verset it's commentary/translation should start from <chapter_number>.<verse_number>

so that while searching it gets picked up

@devkapilbansal
Copy link

Okay, please assign this to me. I will work on this issue

@Gupta-Anubhav12
Copy link
Member

Done
Many thanks for showing interest in Shri Gita

@devkapilbansal
Copy link

Hi @Gupta-Anubhav12
I can see that almost all the verse descriptions contains the chapter name and verse number

For example:-

{
        "authorName": "Swami Adidevananda",
        "author_id": 18,
        "description": "18.76 O King, remembering again and again this wondrous and auspicious dialogue betweenn Sri Krsna and Arjuna, I rejoice again and again.\n\n",
        "id": 4889,
        "lang": "english",
        "language_id": 1,
        "verseNumber": 699,
        "verse_id": 699
    }

Here in description, 18.76 is mentioned.
Now, one thing is unclear to me. Do you want one more field here as verse_reference or something different?

@Nymphalys
Copy link

Hi ,can you assign me this issue ,I would be grateful to complete this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants