New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feature: Set Logfile name via config #604
Labels
enhancement
New feature or improvement
Comments
That's a great suggestion. Can you open a pull request? |
New functionality:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I use git-ftp to host my website. My hosting provider does not allow .log files to be uploaded through their FTP server. This generates a 553 error. To get around this, I had to build this from source, but modifying
git-ftp/git-ftp
Line 53 in 057f7d8
DEPLOYED_SHA1_FILE=".git-ftp.log"
to a file format that was allowed. It would be nice if this was able to be set through the config file.I can submit a pull request if desired, but I am not too familiar with the code. What I think it would look like:
I think the following function needs to be changed
git-ftp/git-ftp
Line 386 in 057f7d8
My understanding is that
$DEPLOYED_SHA1_FILE
is hardcoded in at:git-ftp/git-ftp
Line 53 in 057f7d8
If I'm understanding the code correctly, in the set_deployed_sha1_file function, when get_config() is called, it is passing this hardcoded value. It would be nice to have the option to pass
git-ftp/git-ftp
Line 223 in 057f7d8
".git-ftp.log"
but allow for users to customize.The text was updated successfully, but these errors were encountered: