now TUICalendarOptions properly makes use of all options on the scheduleView and taskView properties #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add JsonIgnore attribute to TUIWeekOptions.daynames gismofx#44
…uleView and taskView properties
|
Thanks for working on this! I punted on this one and haven't come back to finish. I think we need to maintain the taskView and scheduleView enumerated helper types so the api easier/more intuitive for the users... the tricker part is writing the json converters. Would you want to take a go at that? :) Also, please make your PRs to the dev branch. |
…d TUIScheduleView, now it works when assigning a bool value or an string[] value.
|
Something like this? I never tried making a json converter before, but it's working. I also included implicit conversions for string[] and bool values to make it equal to the documentation. Changed to dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties didn't allow the person to use only one of the settings of the property, if you wanted to show only task/milestone on taskView or only allday/time, it wasn't possible.
Now those properties work as a string[], you can define what settings you want in each one by modifying the array or using the helper functions defined in the files.