Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown example outdated #55

Open
AkselMeola opened this issue May 12, 2021 · 0 comments
Open

Graceful shutdown example outdated #55

AkselMeola opened this issue May 12, 2021 · 0 comments

Comments

@AkselMeola
Copy link

(Not sure if this is examples problem or gins problem. )

Hey,

The graceful shutdown example provided in examples/graceful-shutdown does not use gin.Run() and instead calls the http.ListenAndServe() directly.

It looks like gin.Run() also does additional configurations on the engine before starting the server. These methods are private and implementing similar logic without copy/paste is not possible.

Problem: gin.Run() does not expose the server instance anywhere to be able to call Shutdown() on it.

Any ideas ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant