Grammar: smegram and smegram-dev differ, leading to fails in make check

[albbas]

smegram contains this bit:

    <cg><grammar n="spellchecker.bin"/></cg>
    <cg><grammar n="after-speller-disambiguator.bin"/></cg>
    <cg><grammar n="grammarchecker.bin"/></cg>

smegram-dev looks like this:

    <cg><grammar n="./spellchecker.cg3"/></cg>
    <cg><grammar n="./grammarchecker.cg3"/></cg>

smegram adds the after-speller-disambiguator.bin to the pipeline, which seems to shorten the output from the spellchecker.

Example of differing results: msyn-ASgLoc-AAttr.yaml

This is in effect the command that is used when running make check

❯ gtgramtool test -p -c -s ../pipespec.xml -V smegram yaml --output final msyn-ASgLoc-AAttr.yaml
460/187/647

This is in effect the command used when running gtgramtool test msyn-ASgLoc-AAttr.yaml

❯ gtgramtool test -p -c -s ../pipespec.xml -V smegram-dev yaml --output final msyn-ASgLoc-AAttr.yaml
464/182/646

The inclusion of after-speller-disambiguator.bin in smegram leads to four more failing tests, the examples are:

smegram

----------
Test 41/459: Rádji mii vuolgá Kruvatn:s ja manná Røsvatnet bokte, Okstindan, Leirskardalen, Randfjorden ja Dundelandsdalen bokte, mannet baicca gáržžis várreeatnamiid mielde ja nu leatge lunddolaš oazit ránnjáorohagaid bealde lulil, oarjjil ja dávil.
----------
msyn-ASgLoc-AAttr-PASS.yaml
[41/459[FAIL fp2] No errors expected => Randfjorden:[Randfjordena] (msyn-gen-before-postp)
Test 41 - Passes: 2, Fails: 1, Total: 3

smegram-dev

----------
Test 41/459: Rádji mii vuolgá Kruvatn:s ja manná Røsvatnet bokte, Okstindan, Leirskardalen, Randfjorden ja Dundelandsdalen bokte, mannet baicca gáržžis várreeatnamiid mielde ja nu leatge lunddolaš oazit ránnjáorohagaid bealde lulil, oarjjil ja dávil.
----------
msyn-ASgLoc-AAttr.yaml
[41/459[PASS tp] Dundelandsdalen:(Dunderlandsdalen) => Dundelandsdalen:[Dunderlandsdalen] (typo)
msyn-ASgLoc-AAttr.yaml
[41/459[PASS tp] gáržžis:(gáržžes) => gáržžis:[gáržžes] (msyn-attr-not-loc)
Test 41 - Passes: 2, Fails: 0, Total: 2

smegram

----------
Test 114/459: Šattaimet maid ságastallat daid dušši ságáid birra mat máddái čállojit, ja mat dagahit dárbbatmeahttumis rieja Guovdageainnu leansmánnikantuvrra hárrái, lohká Guovdageainnu sátnejođiheaddji Klemet Erland Hætta, ii ge lohkan maidege eará hupman leansmánnevirggi birra.
----------
msyn-ASgLoc-AAttr-PASS.yaml
[114/459[FAIL fp1] máddái:(maiddái) => máddái:[maidda] (typo)
Test 114 - Passes: 1, Fails: 1, Total: 2

smegram-dev

----------
Test 114/459: Šattaimet maid ságastallat daid dušši ságáid birra mat máddái čállojit, ja mat dagahit dárbbatmeahttumis rieja Guovdageainnu leansmánnikantuvrra hárrái, lohká Guovdageainnu sátnejođiheaddji Klemet Erland Hætta, ii ge lohkan maidege eará hupman leansmánnevirggi birra.
----------
msyn-ASgLoc-AAttr.yaml
[114/459[PASS tp] máddái:(maiddái) => máddái:[maiddái, maiddai, máhttái, mahttái, mađđái, máttai, madda, maddii, maidda, mátta] (typo)
msyn-ASgLoc-AAttr.yaml
[114/459[PASS tp] dárbbatmeahttumis:(dárbbatmeahttun) => dárbbatmeahttumis:[dárbbatmeahttun] (msyn-ASgLoc-AAttr)
Test 114 - Passes: 2, Fails: 0, Total: 2

smegram

----------
Test 358/459: Oassálastiid ahkejuohku leamašan njealjje jahkásaččas gitta 70 jahkásažžii.
----------
msyn-ASgLoc-AAttr-PASS.yaml
[358/459[FAIL fp1] njealjje:(njealje) => njealjje:[njeallje, njealji] (typo)
Test 358 - Passes: 0, Fails: 1, Total: 1

smegram-dev

----------
Test 358/459: Oassálastiid ahkejuohku leamašan njealjje jahkásaččas gitta 70 jahkásažžii.
----------
msyn-ASgLoc-AAttr.yaml
[358/459[PASS tp] njealjje:(njealje) => njealjje:[njealje, njeallje, njealji, njealja] (typo)
Test 358 - Passes: 1, Fails: 0, Total: 1

[snomos]

They should not differ. I leave it to @lynnda-hill to fix this, as she probably wants to fix the tests or rules at the same time.

[albbas]

@srcdir@/after-speller-disambiguator.cg3 was removed from smegram-dev in f3103e7, but kept in smegram.
In the previous commit, bef16e9, both smegram-dev and smegram had it.

Don't know if it should have been removed or kept in both at that stage.

[snomos]

@srcdir@/after-speller-disambiguator.cg3 was removed from smegram-dev in f3103e7, but kept in smegram. In the previous commit, bef16e9, both smegram-dev and smegram had it.

Don't know if it should have been removed or kept in both at that stage.

@lynnda-hill or @duomdaamaendra has to answer that. The core idea with that CG file is to remove suggestions (and only speller suggestions) that don’t fit the context, which I think is a good idea. Whether it’s possible or not I can’t tell.