Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotation mark (U+0022) is missing under SHIFT-E02 key from sme-NO and smn keyboard on Mac #4

Open
Trondtr opened this issue Mar 6, 2023 · 12 comments

Comments

@Trondtr
Copy link
Contributor

Trondtr commented Mar 6, 2023

These keyboards give no output for SHIFT-E02
sme-NO, sme-FI, sme-SE, smn, olo

These keyboards give correct output U+0022 ("):
sju, smj, sms, rmn, krl

Despite the error, the source code for all the 5 flawed keyboards do contain the missing U+0022, here e.g. line 21 in keyboard-sme/sme.kbdgen/layouts/se-NO.yaml, a pert of the macOS shift keyboard definition

        § ! " # $ % & / ( ) = ? `

I have not installed or checked more than these 10 keyboards. The error seems to be outside the source code.

Addition: Also ampersand (&), U+0026, key SHIFT-E06, is missing, on all the 5 keyboards having the missing quotation mark. Keyboards having quotation marks also have ampersands.

I am wondering whether keyboard settings in the control panel (I have Ventura 13.2) could affect the issue, but those settings are keyboard-independent and do not explain the 50/50-behaviour of my 10 test keyboards.

se-NO

@Trondtr
Copy link
Contributor Author

Trondtr commented Mar 6, 2023

Still another missing character: E00: U+0027 APOSTROPHE. Missing on se-NO, se-SE,

Interestingly, this character is placed on C12 on the Finnish keyboard. And true enough, on se-FI and smn (spoken in Finland, folloing Finnish basic keyboard layout), this key should be found on C12 (as in Finnish) but is missing from their C12 position in se-FI and smn.

Typing without access to ", ' and & is actually quite annoying...

@Trondtr
Copy link
Contributor Author

Trondtr commented Jun 7, 2023

Summary: The error is not in the .yaml file, as is clearly seen in my March 6th comment: The missing apostrophe U+0027 is missing irrespective of what position it has on the different keyboards. The issue is also independent of font choice. There must thus be some intermediate link from yaml file to character code that is missing.

@Trondtr
Copy link
Contributor Author

Trondtr commented Jun 7, 2023

On a positive note: all three glyps ('"&) are correctly rendered by our mobile phone keyboard for Android, and presumably (not checked) also on the IOS keyboard. One check would thus be to see how our keyboard presents these characters on Windows.

@snomos
Copy link
Member

snomos commented Jun 7, 2023

The three offending glyphs ('"&) are all special characters in xml, and xml is the format used for the keyboard definitions on macOS. It thus looks like these symbols are not properly escaped by kbdgen during compilation. Please file a bug report about that in kbdgen, with a reference to this bug.

@Trondtr
Copy link
Contributor Author

Trondtr commented Jun 7, 2023

Will do, but this does not explain the sju, smj, sms, rmn, krl keyboards, where things work.

@snomos
Copy link
Member

snomos commented Jun 8, 2023

Will do, but this does not explain the sju, smj, sms, rmn, krl keyboards, where things work.

That depends on the build dates of those keyboards. If this is a regression introduced in newer versions of kbdgen (which over the last year or so has undergone major changes), and the functional keyboards were built before that, whereas the bad ones were built later, then it all fits. I have NOT yet checked the build dates as listed in e.g. Divvun Manager.

@snomos
Copy link
Member

snomos commented Jun 8, 2023

Then it could also be other bugs, e.g. not being escaped in certain contexts/cases.

@snomos
Copy link
Member

snomos commented Jun 8, 2023

I checked the dates in Divvun Manager, and both good and bad keyboards are built at similar dates, ie using the same version of kbdgen:

  • bad keyboards
    • sme: 13.12.2022
    • smn: 16.11.2022
  • good keyboards:
    • sju: 16.11.2022
    • smj: 13.12.2022
    • sms: 13.12.2022
    • rmn: 07.02.2023
    • krl: 17.11.2022

This is all from the nightly channel.

@snomos
Copy link
Member

snomos commented Jun 8, 2023

@Trondtr could you uninstall and reinstall the bad keyboards, and double check that you reinstall using the nightly channel? Just to rule out the case that your sme and smn keyboards could be from the stable channel, which is at least as old as May 4, 2022 (for sme) / March 24 2022 (for smn). Ie, if you have the stable channel keyboards, they have been built using an older version of kbdgen than the ones in the nightly channel.

@snomos
Copy link
Member

snomos commented Jun 8, 2023

I did this, and could reproduce the bug. See further details in divvun/kbdgen#10

@snomos
Copy link
Member

snomos commented Jun 13, 2023

This is not fičed in version 1.0.5 in the nightly channel. We still to do a proper release to the stable channel.

@snomos snomos closed this as completed Jun 13, 2023
@Trondtr
Copy link
Contributor Author

Trondtr commented Oct 26, 2023

Quotation marks have dissapeared again. This could be due to DM having reinstalled the disfunctioning one, DM does not open so I cannot tell.

@Trondtr Trondtr reopened this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants