Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery doesn't work, if webcontent of an iframe shows cookie modal #1513

Open
ca-dsgn opened this issue Mar 26, 2024 · 10 comments
Open

Ghostery doesn't work, if webcontent of an iframe shows cookie modal #1513

ca-dsgn opened this issue Mar 26, 2024 · 10 comments
Assignees
Labels
Never-Consent Issues related to Never Consent

Comments

@ca-dsgn
Copy link

ca-dsgn commented Mar 26, 2024

Hi guys,

I just figured out that if a website contains an iframe, which shows a cookie modal (e.g. shown on google.com), the plugin doesn't block it. Is there an option to enable also blocking modals in iframes? If not, is it possible to enhance the plugin to do so? Thank you in advance for your response on this.

Best,
Chris

@chrmod
Copy link
Member

chrmod commented Mar 26, 2024

Hi @ca-dsgn, thank you for your report. As far as I can tell this should work. Can you please provide examples? URLs and screenshots should help us to understand the problem.

@ca-dsgn
Copy link
Author

ca-dsgn commented Mar 27, 2024

Hi @chrmod,
sure, here is a screenshot:
Bildschirmfoto 2024-03-27 um 08 03 59
And the source code:
<iframe src="https://www.google.com/search?igu=1&q=Wismar Weltkrieg 1945" id="google"></iframe>

@ca-dsgn
Copy link
Author

ca-dsgn commented Mar 27, 2024

Here is also what the plugin shows:
Bildschirmfoto 2024-03-27 um 08 05 46

@chrmod
Copy link
Member

chrmod commented Mar 27, 2024

Thank you for sharing!

Something definitely does not look right. I've tested myself and the cookie consent dialog is dismissed correctly thanks to Never-Consent. I'm passing this to @GRadziejewski so he can try to reproduce.

In the meantime, could you please try to test it on a different browser, or with fresh Ghostery installation please?

@chrmod chrmod added the Never-Consent Issues related to Never Consent label Mar 27, 2024
@GRadziejewski
Copy link
Contributor

After clearing the history and browser data + reinstalling the extension, I cannot reproduce this.

Checked on:

Browser: Chrome 123.0.6312.86
OS: Windows 10 Pro 
GBE 8.12.7

Browser: Firefox 124.0.1
OS: Windows 10 Pro 
GBE 8.12.7

Browser: Opera One 108.0.5067.40
OS: Windows 10 Pro
GBE 10.2.14

Browser: Safari 17.4 (19618.1.15.11.12)
OS: macOS Ventura 14.4
GBE 10.2.14

@ca-dsgn
Copy link
Author

ca-dsgn commented Mar 27, 2024

@chrmod @GRadziejewski I removed the plugin from my Chrome Browser (on macOS Ventura) and readded it. After that I restarted Chrome and opened up the page with the iframe (Google URL inside the src attribute). I still get the cookie modal.

I also tested it on Firefox (latest version for macOS) with Ghostery. I have the same issue here.

@chrmod
Copy link
Member

chrmod commented Mar 27, 2024

Oh, I see. This is an iframe with google.com inside. In this case I don't think Never-Consent can work. Let us investigate, maybe there is something we can do.

@chrmod
Copy link
Member

chrmod commented Mar 27, 2024

@ca-dsgn can you please tell us more about your setup. It must be quite special, as you see google trackers reported on your local domain name dev.higris.

From what we are able to determine, our features should work when loaded in the iframe and I cannot reproduce google cookie consent modal when loading google iframe in another page. So it must be something else going on here.

@chrmod
Copy link
Member

chrmod commented Mar 27, 2024

Update - one of our developers was able to reproduce the problem on our side - we will look into it. Stay tuned!

@ca-dsgn
Copy link
Author

ca-dsgn commented May 23, 2024

@chrmod any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Never-Consent Issues related to Never Consent
Projects
None yet
Development

No branches or pull requests

3 participants