New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing S_ISSOCK
for stdin check
#1538
Comments
There hasn't been a single commit in 4 years. Switch from ag to something like ripgrep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Node.js & Bun, spawned subprocesses by default use
socketpair
instead ofpipe
for stdin. This makes it easier to prevent read() & write() calls from blocking without setting a file descriptor toO_NONBLOCK
(i.e. without observably impacting the other process which may or may not handleEAGAIN
correctly)This usually works great, but it unfortunately seems to break using
ag
in a subprocess in Bun.Is this check missing
S_ISSOCK
? or possiblyisatty(0)
?the_silver_searcher/src/options.c
Line 360 in a61f178
Related oven-sh/bun#9510
The text was updated successfully, but these errors were encountered: