-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does it make sense to optimize strlen in this function with for loops? #7268
Comments
IMO, I think it's really not worth doing this. Writing |
@ngxson, I can only fix for |
If you want, another idea would be to add a macro |
We do not want to apply optimizations that serve no real purpose but make the code harder to read. And anyway, the compiler is perfectly capable of optimizing a |
Function
ggml_graph_dump_dot
use 2 strlen() in ggml.cFunction
ggml_visit_parents
use 2 strlen() in ggml.cFunction
ggml_cpy_impl
use 1 strlen() in ggml.cExample:
Before:
After:
The text was updated successfully, but these errors were encountered: