Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump runtime to 47 #1163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump runtime to 47 #1163

wants to merge 2 commits into from

Conversation

TheEvilSkeleton
Copy link
Contributor

Fixes #1155

@TheEvilSkeleton
Copy link
Contributor Author

hmm... all the remaining issues with the CI seem to be out of this MR's scope

@SqAtx
Copy link
Contributor

SqAtx commented Dec 30, 2024

Thanks for looking at it too! I've had 0 free time for software lately :(

hmm... all the remaining issues with the CI seem to be out of this MR's scope

The failures look to be the same as in https://github.com/getting-things-gnome/gtg/actions/runs/12245946645/job/34160890047, which were fixed in 95e33bc. So I think if you just rebase this onto latest master, the tests should work.

If that's the case, and if we've tested that the changes result in a working flatpak, then LGTM.

One day we'll talk about the fact that we're pinning requirements to exact versions, but that doesn't have to be today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SqAtx SqAtx SqAtx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target GNOME 47
2 participants
@TheEvilSkeleton @SqAtx