Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First run tutorial tasks translation problems #1040

Open
kocio-pl opened this issue Mar 3, 2024 · 4 comments
Open

First run tutorial tasks translation problems #1040

kocio-pl opened this issue Mar 3, 2024 · 4 comments

Comments

@kocio-pl
Copy link
Contributor

kocio-pl commented Mar 3, 2024

In the old code base I made a fix for first run tasks to show translated tags (#803) and now the problem is back: we have untranslated tags and body of tasks including these tags, but tasks titles are all good:

Zrzut ekranu z 2024-03-03 01-15-15

I have not look at the new code base, but it might be the same solution (#852) - using dynamic tags (reading them from tasks initially) instead of static ones (a list).

@kocio-pl
Copy link
Contributor Author

kocio-pl commented Mar 3, 2024

Looks like the problem is different - content in most of the tasks is just not translated when searching for tags. The only ones that are translated are simple text ones and for some reason they also don't include tags:

  • "Reporting Bugs"
  • "Learn How to Use the Quick Add Entry"

The interesting problem is lack of translation for "Learn About Plugins", which is also pretty much just a simple text, but it includes escaped quotation marks (\") and so does the rest of untranslated task content.

Maybe something in gettext mechanism is different now, so it can't match string with translated string when there are quotations?

@nekohayo nekohayo changed the title First run translation problems First run tutorial tasks translation problems Mar 3, 2024
@nekohayo
Copy link
Member

nekohayo commented Mar 3, 2024

You might want to compare these with the older ones from 0.6, using Meld and report here on what the differences are that caused these translatable tutorial tasks' contents to change in a way that breaks / makes the translated strings fuzzy. I hadn't had the time to do that myself, but I'd be curious to know; might be an accidental change (like various such accidents I've seen with translatable strings in the GTK4 port).

@kocio-pl
Copy link
Contributor Author

kocio-pl commented Mar 3, 2024

Looks like it was a systematic general notation change for quotation mark (for some reason), for example:

0.6:

"the "Mark as Done" or the "Dismiss" button. Use the "

current:

"the \"Mark as Done\" or the \"Dismiss\" button. Use the first one if the "

Updating translation seems to fix this problem, so we might close this probably, since this is a part of #1041.

@nekohayo
Copy link
Member

nekohayo commented Mar 4, 2024

@diegogangl was this an on-purpose change in the file format or a conversion/import bug or a bug in the way the tutorial tasks are written in the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants