Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's possible for author to be null #101

Open
chadwhitacre opened this issue Feb 7, 2023 · 2 comments
Open

It's possible for author to be null #101

chadwhitacre opened this issue Feb 7, 2023 · 2 comments

Comments

@chadwhitacre
Copy link
Member

Not sure how it happened but it happened on this post. Here's how it showed up in Slack:

null
@dcramer
Copy link
Member

dcramer commented Feb 8, 2023

Digging into this to figure out why it didnt force the redirect.

@dcramer
Copy link
Member

dcramer commented Feb 8, 2023

In root.tsx we check for the attribute, and when its not set we redirect a redirect. However, something changed in Remix (maybe with a prior version upgrade) that this redirect is now completely ignored, and instead the child routes are rendered but without the correct loader data.

dcramer added a commit that referenced this issue Feb 9, 2023
@dcramer
fix: Use email as default name
d3bb8e7 
Quick workaround for missing names and broken redirect

Refs GH-101
@dcramer dcramer mentioned this issue Feb 9, 2023
Merged
dcramer added a commit that referenced this issue Feb 9, 2023
@dcramer
fix: Use email as default name (#107)
0e79b13 
Quick workaround for missing names and broken redirect

Refs GH-101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcramer @chadwhitacre