Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract source map validator as a library #41

Open
connorjclark opened this issue Jun 14, 2019 · 1 comment
Open

Extract source map validator as a library #41

connorjclark opened this issue Jun 14, 2019 · 1 comment

Comments

@connorjclark
Copy link

Would be very useful to have this as a module to use in a CI / test environment. https://github.com/ben-ng/sourcemap-validator isn't ideal because it only returns the first error, and also I believe the implementation here is more detailed.

@connorjclark
Copy link
Author

connorjclark commented Jul 6, 2020

I plan to add a new audit in Lighthouse that displays all the source map validation errors for a given page.

I haven't had a chance to explore the source code here yet, but supposing I fork and expose the validation code as a library, would this repo consider merging my changes and publishing a package?

EDIT: It seems like the meat of the validation is just this one function. In that case, I am tempted to just recreate the function. Also Lighthouse happens to use a different source map library so it'll be necessary to make a new implementation anyhow. But I'll make sure the results match this tool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant