New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-consumers logs with skip-write/no-skip-write flag #5847
Labels
bug
Something isn't working
Comments
I can confirm that the log output is swapped, but in terms of actual behavior the |
untitaker
added a commit
that referenced
this issue
May 15, 2024
the `finish()` function returns whether the write happened, as such the logs were messed up. Fix #5847
#5920 this should fix the log |
untitaker
added a commit
that referenced
this issue
May 15, 2024
the `finish()` function returns whether the write happened, as such the logs were messed up. Fix #5847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
sentry/snuba 24.4.2
Steps to Reproduce
--no-skip-write
flagExpected Result
According to: https://github.com/getsentry/snuba/blob/24.4.2/snuba/cli/rust_consumer.py#L104-L109
I expect that consumer follow config flag
--no-skip-write
and write rows to clickhouse and correctly report it to logsActual Result
Consumer actually writes to clickhouse with
--no-skip-write
, but reports that writing skipped, which looks like inverted interpretation of flagIf I run rust consumer with
--skip-write
flag, it stops writing to clickhouse, but reports{"message":"Inserted 1 rows"}
in logsThe text was updated successfully, but these errors were encountered: