Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue Retries will start from 1 instead of 0 #966

Open
nohant opened this issue Jan 14, 2025 · 4 comments
Open

Queue Retries will start from 1 instead of 0 #966

nohant opened this issue Jan 14, 2025 · 4 comments
Assignees

Comments

@nohant
Copy link

nohant commented Jan 14, 2025

How do you use Sentry?

Sentry SaaS (sentry.io)

SDK version

4.10.2

Laravel version

v11.29.0

Steps to reproduce

we implemented the queue system on our laravel integration, and we noticed that everytime a job would start, we would see a "1" under retries in the sentry interface.

But i think this is because of the laravel concept of tries

if a job is run once and its ok, i dont think it should be 1 under retry.

Expected result

We should see 0 under the retry column if the job hasnt restarted.

Actual result

we see 1 under the retry column with a successful job.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 14, 2025
@PellegrinoDurante
Copy link

Or maybe rename "Retries" to "Tries"?

@nohant
Copy link
Author

nohant commented Jan 14, 2025

Or maybe rename "Retries" to "Tries"?

this would even be easier and better ✌

@stayallive
Copy link
Collaborator

Good catch, renaming is not an option (and would probably name it "attempts" te keep in line with Laravel). But instead we'll fix the retry count to be correct with #967.

@nohant
Copy link
Author

nohant commented Jan 14, 2025

thank you mate that would be super nonetheless :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants