How do you use Sentry?

Sentry SaaS (sentry.io)

SDK version

Sentry PHP 4.7.0

Steps to reproduce

I might be confused or misunderstanding something, but in looking at Sentry\Laravel\Tracing\Middleware, the transaction is only set on the hub if it was sampled:

        if (!$transaction->getSampled()) {
            return;
        }

        $this->transaction = $transaction;

        SentrySdk::getCurrentHub()->setSpan($this->transaction);

However, code in the PHP SDK, such as the getTraceparent(), getW3CTraceparent() and getBaggage() functions, looks at the span on the hub to see if it was sampled. Therefore, I would have assumed that we want to put a transaction that is not sampled on the hub.

Is the Laravel SDK "doing it wrong" and it should be putting even unsampled transactions on the hub? Or am I just confused and misunderstanding things, which is quite possible :)

Expected result

I think an unsampled transaction should be on the hub, so that it can be determined that is was not sampled.

Actual result

The sampling decision, which was actually false, appears to be null.