Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to add custom tags like pod.Labels, Option to set SampleRate and set Event Message #85

Open
rajesh-dhakad opened this issue Jan 4, 2024 · 1 comment

Comments

@rajesh-dhakad
Copy link

rajesh-dhakad commented Jan 4, 2024

Option to add custom tags like pod.Labels: We make use of labels to identify resources belonging to applications and/or teams. It would be really useful to have those as tags in sentry to filter by them. So I would propose adding labels as tags.

Option to set SampleRate: We should have option to specify SampleRate.

Option to set Event Message: This helps in grouping.

To fulfil my requirements i made changes by forking this repo: master...rajesh-dhakad:sentry-kubernetes:master

But if we can include this in parent repo would be great help.

@tonyo
Copy link
Member

tonyo commented Jan 24, 2024

Thanks for the suggestions!

Option to set SampleRate: We should have option to specify SampleRate.

Making the sample rate configurable (via an environment variable) sounds good, a PR with the change would be welcome 👍

Option to add custom tags like pod.Labels

We could probably expose all pod (and other resources') labels as tags by default, but there might be some caveats with that (e.g. making sure that label names and values are properly mapped to Sentry tags). I'd suggest to have an opt-in environment variable flag: if enabled, we add a Sentry tag for each label on the resource. And then if everything works fine and stable, we can make it a default (and/or opt-out) behavior. How does that sound?

Option to set Event Message: This helps in grouping

You mean the part with extracting "app.kubernetes.io/name" label, and then using it instead of the pod name? Here I feel like we'll need a more generic/flexible solution. Could you provide more info on your use case? I wonder if can be solved with some of the ideas we at Sentry had in mind for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants