Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning if release passed in is not an object #455

Open
HazAT opened this issue Dec 18, 2023 · 4 comments
Open

Raise warning if release passed in is not an object #455

HazAT opened this issue Dec 18, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@HazAT
Copy link
Member

HazAT commented Dec 18, 2023

When using the Vite Plugin to inject Debug IDs and upload it to Sentry:
image (34)
Sentry CLI Prints this output, not showing the set Release
image (33)

@lforst
Copy link
Member

lforst commented Dec 19, 2023

Good ol rtfm 😄 https://www.npmjs.com/package/@sentry/vite-plugin#releasename. It's release.name not release.

@HazAT
Copy link
Member Author

HazAT commented Dec 19, 2023

Oh boy - maybe we should at least print a warning or something.
In the SDK it's just release that's a foot gun I would say.

@lforst
Copy link
Member

lforst commented Dec 19, 2023

It might be you being used to the v1 api of the webpack plugin which had the release option. We have types nowadays (even in JS) so I think printing warnings for wrong API usage is redundant.

@HazAT
Copy link
Member Author

HazAT commented Dec 19, 2023

I am talking about how you set a release in the SDK, it's not an object there, it's a string.
This is not a high prio item but a nice to have IMHO. I changed the title of the issue to make it obvious.

@HazAT HazAT changed the title Vite Plugin not passing along set Release Raise warning if release passed in is not an object Dec 19, 2023
@HazAT HazAT added the enhancement New feature or request label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants