fix(logrus-hook): Don't throw error if sentry event is dropped #579
Conversation
When using the logrus hook to send logrus logs to sentry, an error was logged when the corresponding sentry event is being dropped client-side. This happens for example when using the `BeforeSend` event transformation function. This should not be considered an error. Resolves #578
| @@ -121,7 +121,6 @@ func (h *Hook) Fire(entry *logrus.Entry) error { | |||
| if h.fallback != nil { | |||
| return h.fallback(entry) | |||
| } | |||
| return errors.New("failed to send to sentry") | |||
There was a problem hiding this comment.
I'm questioning the usefulness of handling the return value of CaptureEvent altogether. By default, the ID is always returned, even if the HTTPTransport does not successfully submit the event to Sentry, as we do not have a back channel to the main thread. So this only applies when using the HTTPSyncTransport.
Codecov ReportBase: 79.14% // Head: 79.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 79.14% 79.16% +0.02%
==========================================
Files 38 38
Lines 3856 3855 -1
==========================================
Hits 3052 3052
+ Misses 703 702 -1
Partials 101 101
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I have figured out that the error can be suppressed by setting a fallback: hook.SetFallback(func(entry *log.Entry) error {
return nil
})Given this solution the PR is not needed anymore. |
When using the logrus hook to send logrus logs to sentry, an error was logged when the corresponding sentry event is being dropped client-side. This happens for example when using the
BeforeSendevent transformation function.This should not be considered an error.
Resolves #578