-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Refactor HubExtensions and SentrySdk #2490
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
See conversation thread here.
The
HubAdapter
passes it's work toSentrySdk.CurrentHub
(a static instance ofHub
).HubExtensions
andSentrySDK
both employ switch expression in multiple locations to determine whether to call a real internal implementation ofIHubEx
or the nearest equivalent public implementation of something fromIHub
(implicitly onDisabledHub
, since it's the only hub that implementsIHub
but notIHubEx
). That could probably be achieved more simply by havingDisabledHub
implementedIHubEx
and then do the same (returndefault
or whatever else the extension methods are doing).The text was updated successfully, but these errors were encountered: