Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcemaps inject should fall back to co-located source maps if exact path can't be found #1870

Open
brettdh opened this issue Dec 21, 2023 · 5 comments · May be fixed by #1871
Open

sourcemaps inject should fall back to co-located source maps if exact path can't be found #1870

brettdh opened this issue Dec 21, 2023 · 5 comments · May be fixed by #1871

Comments

@brettdh
Copy link
Contributor

brettdh commented Dec 21, 2023

Environment

What version of the CLI and what OS are you running?

Sentry CLI 1.23.0, macOS Ventura 13.4

Steps to Reproduce

Similar to #1846:

  1. Create a .js file with a corresponding .js.map file in the same directory
  2. Add a source map comment pointing to a path that doesn't exist locally; e.g.
    //# sourceMappingURL=/_static/build/foo.js.map
    
    Note: this is a mostly-real example from a starter Remix app. The path here is the default when creating a new app from the grunge stack, but this issue will occur for any static assets path, whether or not it has a URL scheme and domain.
  3. Run sentry-cli sourcemaps inject foo.js*

Alternatively, though it was created to repro a different bug, you can also repro this bug by following the steps here, ignoring the AWS bits and running npm run build instead of any of the other scripts. The sentry-cli sourcemaps inject step will show missing debug IDs for the sourcemap files.

Expected Result

JS file and sourcemap file both have debug ID injected

Actual Result

Only JS file has debug ID injected

Logs

When filing a bug report, please attach debug logs, either by using --log-level=debug flag or SENTRY_LOG_LEVEL=debug environment variable.

@adinauer
Copy link
Member

@brettdh thanks for opening this issue. Might take a while for us to look at it with the holidays coming up.

@brettdh
Copy link
Contributor Author

brettdh commented Dec 21, 2023

Should have mentioned - I'm working on a PR already, as it's a trivial addition to my last one.

brettdh added a commit to brettdh/sentry-cli that referenced this issue Dec 21, 2023
brettdh added a commit to brettdh/sentry-cli that referenced this issue Dec 21, 2023
brettdh added a commit to brettdh/sentry-cli that referenced this issue Dec 21, 2023
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@brettdh
Copy link
Contributor Author

brettdh commented Jan 18, 2024

Sorry, I've let the PR here become idle. I'll try to get back to it soon.

@szokeasaurusrex
Copy link
Member

I put a "Status: Backlog" label on this PR so StaleBot keeps it open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants