Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong commit selection #139

Open
MaximeLaurenty opened this issue Apr 7, 2023 · 2 comments
Open

Wrong commit selection #139

MaximeLaurenty opened this issue Apr 7, 2023 · 2 comments

Comments

@MaximeLaurenty
Copy link

MaximeLaurenty commented Apr 7, 2023

Github Sentry Action Release Bug Report

Environment

How do you use this action?
Standard Github runners, container built on top of archlinux:base

Which version of the action?
getsentry/[email protected]

Steps to Reproduce

  1. Setup action in our CI, triggered on every commit to master
- name: Create Sentry release
  uses: getsentry/[email protected]
  env:
    SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
    SENTRY_ORG: ${{ secrets.SENTRY_ORG }}
  with:
    environment: prod
    projects: frontend
    sourcemaps: frontend
    version: ${{ github.sha }}
    dist: ${{ github.sha }}
    url_prefix: "~"
  1. Make multiples commits to master
  2. Check info about releases into Sentry

Expected Result

Have only 1 commit in every release.

Actual Result

Most of the time, commits are properly set within releases (just 1), but sometimes a discrepancy happens and a release contains multiple commits (for which releases already exist):
see here commits in the latest release (including previous fe51918):
Screenshot 2023-04-07 at 15 36 02 - sentry commit list
see here the release just before (which includes fe51918):
Screenshot 2023-04-07 at 15 40 31 sentry release list
links to sentry if you have access: erroneous release, right release before that & list of our releases
There is no relevant info in the logs of the action.

@mmospanenko
Copy link

mmospanenko commented May 12, 2023

maybe it requires more commits in current session?

      - uses: actions/checkout@v3
        with:
          fetch-depth: 0

@MaximeLaurenty
Copy link
Author

How would adding more commits to the available history in github action lead to less commits on sentry releases?
Fyi all our releases already have at least one commit.
(and in our case: each release should have exactly one commit given we create a release and deploy after every commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants