Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob support for sourcemaps #116

Open
austince opened this issue Nov 28, 2022 · 4 comments
Open

Glob support for sourcemaps #116

austince opened this issue Nov 28, 2022 · 4 comments

Comments

@austince
Copy link

It would be nice not to have to expand this ourselves, eg. just:

with:
  sourcemaps: ui/build/static/js/*.map

This could probably be done with just running the array through minimatch or such.

Originally posted by @amcdnl in #43 (comment)

@armenzg
Copy link
Member

armenzg commented Nov 30, 2022

Thanks @austince for filing! At the moment, we're not currently investing in the action but we will look at this when we do.

@austince
Copy link
Author

Nice, thanks @armenzg!

we're not currently investing in the action

Does this apply to any changes, or just writing the feature? We may be able to contribute a PR if you'd have the bandwidth to review, but understand if not.

@armenzg
Copy link
Member

armenzg commented Dec 1, 2022

Nice, thanks @armenzg!

we're not currently investing in the action

Does this apply to any changes, or just writing the feature? We may be able to contribute a PR if you'd have the bandwidth to review, but understand if not.

We welcome PRs! Tag me and I will be able to help.

@ricardo-dematos
Copy link

We are using

with:
  sourcemaps: ui/build/static/js/

and it uploads all the sourcemaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants