Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files to src/container/ #1088

Open
matthew-white opened this issue Dec 9, 2024 · 0 comments
Open

Move files to src/container/ #1088

matthew-white opened this issue Dec 9, 2024 · 0 comments
Labels
refactor Improves code without altering behavior

Comments

@matthew-white
Copy link
Member

We have a bunch of top-level files in src/. A lot of them create objects that manage app state and are stored in container:

  • alert.js
  • unsaved-changes.js
  • scroll-behavior.js
  • i18n.js
  • router.js
  • routes.js

I think it'd be cleaner to move these files to their own directory. I'm thinking src/container/. Then src/container.js could become src/container/index.js.

I had this thought in mind while working on #1067. I added src/container/hover-card.js to manage the state of the hover card. It's the first file in src/container/.

@matthew-white matthew-white added the refactor Improves code without altering behavior label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves code without altering behavior
Projects
None yet
Development

No branches or pull requests

1 participant