Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preloads for instanceID in test forms #760

Open
lognaturel opened this issue Feb 4, 2023 · 0 comments
Open

Use preloads for instanceID in test forms #760

lognaturel opened this issue Feb 4, 2023 · 0 comments
Labels
testing Integration tests, unit tests

Comments

@lognaturel
Copy link
Member

lognaturel commented Feb 4, 2023

There are various test forms that use calculates to set instanceID. This is problematic for clients because calculates can be reevaluated without warning and so the instanceID is not stable on the client side.

It doesn't matter for Central but sometimes these test forms get used as examples or starting points in unexpected contexts. Let's change those to what pyxform outputs and is generally the expected binding for instanceID:

<bind jr:preload="uid" nodeset="/data/meta/instanceID" readonly="true()" type="string"/>
@matthew-white matthew-white added the testing Integration tests, unit tests label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Integration tests, unit tests
Projects
None yet
Development

No branches or pull requests

2 participants