Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow maintenance page to be non-routable #33

Open
woutgg opened this issue Dec 1, 2019 · 2 comments · May be fixed by #37
Open

Allow maintenance page to be non-routable #33

woutgg opened this issue Dec 1, 2019 · 2 comments · May be fixed by #37

Comments

@woutgg
Copy link

woutgg commented Dec 1, 2019

I expected that it would be possible to specify a page with routable: false in its frontmatter, but this causes a 404 to show up instead.

The error plugin does allow this so I quickly glanced the code there. I am not familiar with the plugin API so I'll just link to the differences in page handling between the plugins in case this saves someone else looking that up.

@NicoHood
Copy link
Contributor

I guess this is a duplicate of #27

A workaround would be:

redirect: /

@NicoHood
Copy link
Contributor

NicoHood commented Dec 10, 2020

I am not sure why this works for the error plugin, but not the maintainance plugin. I assume that there is some internal grav code the removes the routable attribute (not in the plugin code, but rather related to the event).

If that is true (@rhukster ?) we could simply modify the page header and set routable always to true. Does that sound correct?

Edit: working further with grav it turns out, that setting routable always to true and in the page markdown itself to false seems like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants