Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes #37

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Multiple fixes #37

wants to merge 7 commits into from

Conversation

NicoHood
Copy link
Contributor

@NicoHood NicoHood commented Dec 10, 2020 •
edited

  1. Fixed login dependency Error when login plugin disabled #35
  2. Adds default status code to config as requested here: feat. custom HTTP status code #22 #28 (comment)
  3. Fixed a blueprint issue
  4. Moved form to plugin config, so one can define a custom maintenance.md file but still make use of the login functionality. The form can be customized via its plugin config file (similar to the comments plugin)
  5. The form was renamed to maintenance_login
  6. Fix Feature request: disallow robot crawling #25
  7. Set default expire to 0, similar to error plugin: https://github.com/getgrav/grav-plugin-error/blob/develop/error.php#L57-L61

I also would like to fix #33 But I am not yet sure how

Here is a screenshot of 4.: grafik

@NicoHood NicoHood mentioned this pull request Dec 10, 2020
Merged
@NicoHood NicoHood changed the title WIP Multiple fixes Multiple fixes Dec 10, 2020
@NicoHood NicoHood mentioned this pull request Dec 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow maintenance page to be non-routable Feature request: disallow robot crawling
1 participant
@NicoHood