-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpecDatastore is not reset when multiple specs are executed on the same runner #2270
Comments
Thanks for pointing out the issue. Do you want to send a pull request to fix this issue as you've already figured the spot? |
This was referenced Oct 17, 2022
@barnesjohnraymond has opened #2299 to address this, but I worry that the proposed change will break table driven execution. I am going to try and replicate this issue, @F7502 / @@barnesjohnraymond - do you have a sample project that can help me replicate this? If not, I'll try to create something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We are running multiple test specs (using the
gauge-ts
runner) in parallel and we have more test specs than runners. In this setup some test specs are executed on the same runner sequentially. We observed that the Specification DataStore is not properly reset between such sequential test spec executions although the documentation clearly states:Values are cleared after every specification is executed.
I digged a bit into the code and found this here:
gauge/execution/specExecutor.go
Line 84 in 363eb96
If
executeBefore
is false, the spec data store will not be reset before the spec is executed. However, when multiple specs are run on the same runner,executeBefore
is only true for the first spec:loop over all specs:
gauge/execution/simpleExecution.go
Line 129 in 363eb96
setting to
false
after first spec:gauge/execution/simpleExecution.go
Line 134 in 363eb96
Expected behavior
The specification data store should be reset before every test spec execution.
Versions:
"@getgauge/cli": "1.4.3"
The text was updated successfully, but these errors were encountered: