Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible goroutine leaking #14

Open
FrontMage opened this issue Mar 1, 2018 · 1 comment
Open

Possible goroutine leaking #14

FrontMage opened this issue Mar 1, 2018 · 1 comment
Labels
help wanted

Comments

@FrontMage
Copy link

It's OK using on a one time command, while using wow with prompt, it consumes more cpu usage every time it starts, doesn'st seem to clean up it's goroutines.
@falzm
Copy link

falzm commented Jan 7, 2019

Agreed, there is definitely something wrong with the goroutines created in the Start() method. Here is pprof trace of about 2 minutes running wow:

screenshot 2019-01-07 at 14 38 47

screenshot 2019-01-07 at 14 39 24

@falzm falzm mentioned this issue Jan 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@falzm @gernest @FrontMage