Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback languages not considered in NewsAvailability check #1889

Open
philipmasser opened this issue Oct 20, 2022 · 1 comment
Open

Fallback languages not considered in NewsAvailability check #1889

philipmasser opened this issue Oct 20, 2022 · 1 comment

Comments

@philipmasser
Copy link

Bug Report

I have a site set up with multiple languages. Of those, only 2 are actively used, the others are for domain management.
Thus, those site languages use fallback languages.

The relevant situation is as follows:

  • Main site is in language 0 (DE)
  • site "EN" uses language 2, this is the target translated language
  • site "EU" uses language 5, with fallback to language 2 in "strict" mode
  • every story is entered in default language (0) and EN (2)

All pages and news are displayes correctly in all sites / languages.

However, <link rel="alternate" > are NOT generated for the EU target.

Current Behavior
"alternate" links are not generated for stories, when the translated story is in a fallback-language of the site language.

Expected behavior/output
"alternate" link is generated

Environment

  • TYPO3 version(s): 10.4.21
  • news version: 8.6.0
  • Is your TYPO3 installation set up with Composer (Composer Mode): yes
  • OS: Ubuntu 18.04.06

Possible Solution
I have a patch that will include checks for fallback languages Ids in the check

news-fallback-language-check-fix.patch.txt

Additional context

@philipmasser
Copy link
Author

I know this is for an old version of news, but maybe the bug still exists in newer versions, and my patch can give insights for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant