Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code not working for multiple particle objects #31

Open
SachinJalan opened this issue Aug 15, 2023 · 1 comment
Open

Code not working for multiple particle objects #31

SachinJalan opened this issue Aug 15, 2023 · 1 comment

Comments

@SachinJalan
Copy link

SachinJalan commented Aug 15, 2023

Steps to generate the issue.

  1. Generate an example with a single cell and a single particle object and run the solver.
  2. Generate an example with exactly same configuration except have 2 particle objects having same material properties and element_ids.
    The results does not match.
    Issue in the code:- In this line of the code scheme.py , compute_nodal_mass function will be called same number of times as the number of particle objects and in this function this line will set the nodal mass to 0 every time the function is called hence the nodal mass for the last called Particle object would remain. Similar issue with the compute_nodal_momentum function.
@chahak13
Copy link
Collaborator

Thanks for pointing this out. I also realised this and #27 should resolve this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants