-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character data should include their id #110
Comments
I agree, it's very hard to identify characters. For example, vision is added to name for Traveler and others are identified by their name. |
I think it would be great, I had to make my own json file, and then I merged the two of them together. |
Also agree identifiers would be helpful, created PR with the ids: #220 |
Hey, I think it would be useful for the character data to include the identifier of the character.
This way, when parsing data from
https://api.genshin.dev/characters/all
, it would be possible to determine the URL for the icon of each character.Happy to do it myself, if we can agree that this is a useful feature.
The text was updated successfully, but these errors were encountered: