Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character data should include their id #110

Closed
thomas-tcj opened this issue Oct 22, 2021 · 3 comments · Fixed by #279 · May be fixed by #220
Closed

Character data should include their id #110

thomas-tcj opened this issue Oct 22, 2021 · 3 comments · Fixed by #279 · May be fixed by #220
Labels
enhancement New feature or request

Comments

@thomas-tcj
Copy link
Contributor

Hey, I think it would be useful for the character data to include the identifier of the character.

This way, when parsing data from https://api.genshin.dev/characters/all, it would be possible to determine the URL for the icon of each character.

Happy to do it myself, if we can agree that this is a useful feature.

@TheMaskedPony
Copy link

I agree, it's very hard to identify characters. For example, vision is added to name for Traveler and others are identified by their name.
In my opinion, Ids should be artificial and given in data. Anyway it would be very useful to include ids.

@LolnationCH
Copy link

I think it would be great, I had to make my own json file, and then I merged the two of them together.
Here it is if anyone want to use it (Had to put .md cause github don't want .json...)
CharactersId.json.md

@xannem
Copy link
Contributor

xannem commented Aug 5, 2023

Also agree identifiers would be helpful, created PR with the ids: #220

@xannem xannem mentioned this issue Aug 5, 2023
@man90es man90es added the enhancement New feature or request label May 16, 2024
@man90es man90es linked a pull request May 16, 2024 that will close this issue
@man90es man90es linked a pull request May 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants