-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automated tests for Debian 8, fix systemd not enabling #191
Comments
Funny enough... tests are passing locally without me changing anything, even though when I check inside the container:
So I should probably add in a test to verify the service is actually enabled. Or at least file a bug (or find an existing bug) with Ansible's |
Yay, I got the Debian 8 test to fail, while it's working on other systemd distros :) https://travis-ci.org/geerlingguy/ansible-role-php/builds/232679400 |
Any chance it's this one ansible/ansible-modules-core#3764 (comment) |
Seems that was the bug, https://travis-ci.org/geerlingguy/ansible-role-php/jobs/232887274#L756 Can't really go with The upstream issue ansible/ansible#22303 |
@oxyc - D'oh! Well, another option is to:
|
(If you want to make those changes in your PR I'll merge it and close my original one) |
I was just debugging a bit while waiting for a provision to finish at work (production drupal vm 🎉) :) Feel free to fix it, otherwise I can take a look later after I finish work. |
Fixes #191: Add automated tests for Debian 8, fix systemd service issue.
I've been hitting an issue with the
php7.1-fpm
service not showing as enabled viasystemctl status
over in Drupal VM (when building a Docker container for the VM)—see geerlingguy/drupal-vm#1366, the first issue in that list.Then I realized I don't have any automated test coverage in this repo, and that's probably why there are little broken things like this! I need to add automated test coverage, fixing any issues that are exhibited by said tests.
The text was updated successfully, but these errors were encountered: