Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to next event #498

Merged
merged 4 commits into from
Jan 26, 2025
Merged

Go to next event #498

merged 4 commits into from
Jan 26, 2025

Conversation

james-collapse
Copy link
Collaborator

@james-collapse james-collapse commented Jan 19, 2025

Fixes #467

Description

  • Adds button to skip to next event if there are no events for the selected filter.

Tested on both Event and Partner pages:

Screen.Recording.2025-01-19.at.19.38.58.mov

@james-collapse james-collapse self-assigned this Jan 19, 2025
Copy link

Connected to Huly®: TD-499

Copy link

cloudflare-workers-and-pages bot commented Jan 19, 2025

Deploying the-trans-dimension with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0311df9
Status: ✅  Deploy successful!
Preview URL: https://1024365a.the-trans-dimension.pages.dev
Branch Preview URL: https://skip-to-next-date-with-event.the-trans-dimension.pages.dev

View logs

Copy link
Member

@kimadactyl kimadactyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic to me! I can't comment on the code but its awesome.

I also only just noticed theres currently no facility to page forward and back a week - did we not have this before? Will make a new feature.

Copy link
Member

@katjam katjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but you need to run it through the elm-format. I can see lots of places where the formatting is off.

The formatting convention is accepted very widely across the whole community which makes it easier to swap between projects in terms of readability.

I have my editor set to do that on save, but we could also consider setting up a pre-commit hook that does it additionally. The advantage of doing it on save means you can type fast ans sloppy and get the corrections in real time.

You can run the node script manually as npm run format

@katjam
Copy link
Member

katjam commented Jan 22, 2025

Running elm-format will also help with those merge conflicts.

@kimadactyl
Copy link
Member

we could also consider setting up a pre-commit hook that does it additionally

yeah i think this is a must if we want to enforce it :) are you ok to make a ticket? (or just do it?)

Copy link
Member

@katjam katjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

@james-collapse james-collapse merged commit 8b52991 into main Jan 26, 2025
1 check passed
@james-collapse james-collapse deleted the skip-to-next-date-with-events branch January 26, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to find the next event if there are no events on today
3 participants