-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to next event #498
Go to next event #498
Conversation
Connected to Huly®: TD-499 |
Deploying the-trans-dimension with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic to me! I can't comment on the code but its awesome.
I also only just noticed theres currently no facility to page forward and back a week - did we not have this before? Will make a new feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but you need to run it through the elm-format
. I can see lots of places where the formatting is off.
The formatting convention is accepted very widely across the whole community which makes it easier to swap between projects in terms of readability.
I have my editor set to do that on save, but we could also consider setting up a pre-commit hook that does it additionally. The advantage of doing it on save means you can type fast ans sloppy and get the corrections in real time.
You can run the node script manually as npm run format
Running |
yeah i think this is a must if we want to enforce it :) are you ok to make a ticket? (or just do it?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now!
Fixes #467
Description
Tested on both Event and Partner pages:
Screen.Recording.2025-01-19.at.19.38.58.mov