-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow linking directly to Manchester or London listings #466
Comments
@kimadactyl Would something like https://transdimension.uk/?filter=manchester be OK or did you have something else in mind? We could rig up https://manchester.transdimension.uk etc... |
that works great. as long as you can link to it, and once set it stays persistant when you change pages, its all good |
It won't persist between page navigations by default, but we can make it do that. Do we want the persistent filter in the url to also to be set when people click a region button on any of the 3 pages? |
that makes sense to me yeah! |
There's a preview up here if you want to see it working https://46afbbb8.the-trans-dimension.pages.dev append ?filter=london or ?filter=manchester on index, events or partners it's case agnostic. |
So yes, persist the filter in the url between page navigations & set it whenever one of the buttons is pressed on any page (might cause the page to refresh). If we do want this model where the filter persists, it might make more sense to use the other design pattern where there is a landing page that leads to manchester.transdimension.uk or london.transdimension,uk |
I can release as it is now and do the enhancement over next few days. Are there any other "urgent" broken things preventing the release? |
i think #467 you could argue might be needed for release - it looks kinda bad if people are scrollign throgh multuple days with nothing on. depends how many |
OK I can take a look and see how |
Filtering is possible now, but does not persist. Made a new issue to cover that. |
Reopening this one as original AC not met - hopefully ground all set now though! |
User story
As someone living in Manchester or London and wanting to send a link to a friend, I want to be able to send a URL that only contains London or Manchester listings, in order that people don't get confused which listings are which.
As someone plugging the Manchester expansion on social media, I want to be able to track clicks to Manchester listings specificallly, in order that I can judge the success of my campaign
Acceptance criteria
Split this off so we could get live with progress so far
Implementation notes & questions
Implementation plan
Huly®: TD-467
The text was updated successfully, but these errors were encountered: