Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking directly to Manchester or London listings #466

Open
2 of 6 tasks
kimadactyl opened this issue Dec 3, 2024 · 11 comments · May be fixed by #493
Open
2 of 6 tasks

Allow linking directly to Manchester or London listings #466

kimadactyl opened this issue Dec 3, 2024 · 11 comments · May be fixed by #493
Assignees
Labels
vvv Very Very Valuable

Comments

@kimadactyl
Copy link
Member

kimadactyl commented Dec 3, 2024

User story

As someone living in Manchester or London and wanting to send a link to a friend, I want to be able to send a URL that only contains London or Manchester listings, in order that people don't get confused which listings are which.

As someone plugging the Manchester expansion on social media, I want to be able to track clicks to Manchester listings specificallly, in order that I can judge the success of my campaign

Acceptance criteria

  • Region selector persists after being selected
  • Region is saved in the route
    • I can generate a link to just Manchester events
    • I can generate a link to just Manchester partners
  • If I press the back button it saves that I have selected Manchester

Split this off so we could get live with progress so far

Implementation notes & questions

Implementation plan

Huly®: TD-467

@kimadactyl kimadactyl added the vvv Very Very Valuable label Dec 3, 2024
@katjam
Copy link
Member

katjam commented Dec 5, 2024

@kimadactyl Would something like https://transdimension.uk/?filter=manchester be OK or did you have something else in mind?

We could rig up https://manchester.transdimension.uk etc...

@kimadactyl
Copy link
Member Author

that works great. as long as you can link to it, and once set it stays persistant when you change pages, its all good

@katjam
Copy link
Member

katjam commented Dec 6, 2024

It won't persist between page navigations by default, but we can make it do that. Do we want the persistent filter in the url to also to be set when people click a region button on any of the 3 pages?

@kimadactyl
Copy link
Member Author

that makes sense to me yeah!

@katjam
Copy link
Member

katjam commented Dec 6, 2024

There's a preview up here if you want to see it working https://46afbbb8.the-trans-dimension.pages.dev

append ?filter=london or ?filter=manchester on index, events or partners it's case agnostic.

@katjam
Copy link
Member

katjam commented Dec 6, 2024

So yes, persist the filter in the url between page navigations & set it whenever one of the buttons is pressed on any page (might cause the page to refresh).

If we do want this model where the filter persists, it might make more sense to use the other design pattern where there is a landing page that leads to manchester.transdimension.uk or london.transdimension,uk

@katjam
Copy link
Member

katjam commented Dec 6, 2024

I can release as it is now and do the enhancement over next few days. Are there any other "urgent" broken things preventing the release?

@kimadactyl
Copy link
Member Author

i think #467 you could argue might be needed for release - it looks kinda bad if people are scrollign throgh multuple days with nothing on. depends how many e that is i think lol

@katjam
Copy link
Member

katjam commented Dec 6, 2024

i think #467 you could argue might be needed for release - it looks kinda bad if people are scrollign throgh multuple days with nothing on. depends how many e that is i think lol

OK I can take a look and see how e it is. It's currently like that anyway so the only "worse" thing would be that Manchester has less events and so more likely for people to experience.

@katjam
Copy link
Member

katjam commented Dec 8, 2024

Filtering is possible now, but does not persist. Made a new issue to cover that.

@kimadactyl
Copy link
Member Author

Reopening this one as original AC not met - hopefully ground all set now though!

@mateusfpleite mateusfpleite self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vvv Very Very Valuable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants