Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if disabling nested named operations applies in all situations or just adding #3175

Open
GCHQDeveloper314 opened this issue Mar 19, 2024 · 0 comments
Labels
bug Confirmed or suspected bug named-operation Specific to/touches Named Operations
Milestone

Comments

@GCHQDeveloper314
Copy link
Member

Describe the bug
The code to check for if nested named operations are allowed exists in AddNamedOperationHandler.java and checks if a new named operation to add contains further named operations.

However, it doesn't seem that any checks are done on execution. Potentially allowing for the following situation:

  1. Graph configuration is initially setup to allow nesting.
  2. Named Operation involving nesting is added.
  3. Graph configuration is then changed so that nesting is not allowed.
  4. Existing Named Operation involving nesting can still be executed (but new ones not added). Admins wouldn't be expecting this to be allowed.

Additional context
The above should be investigated and if confirmed changes potentially made, or the current situation documented.

@GCHQDeveloper314 GCHQDeveloper314 added bug Confirmed or suspected bug named-operation Specific to/touches Named Operations labels Mar 19, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the Backlog milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug named-operation Specific to/touches Named Operations
Projects
None yet
Development

No branches or pull requests

1 participant