-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FieldsEmbed Mode Not Working at DJSv13 #69
Comments
gazmull
added
breaking change
This may contain significant interface modifications
critical
This is important
labels
Jul 16, 2021
gazmull
added
bug/error
Something isn't working/right
and removed
breaking change
This may contain significant interface modifications
labels
Jul 16, 2021
gazmull
added a commit
that referenced
this issue
Aug 3, 2021
- Fixes #69 Signed-off-by: gazmull <[email protected]>
any updates on this? |
Any quick fix for this? I wan't to just use it with dcjs13 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For upcoming release of PaginationEmbed v3
FieldsEmbed
mode has an extension methodformatField
which still overrides the field value/s with function for array mapping, however with discordjs/discord.js#4880, now it causes the module to throw out an error due to field value/s being non-string type.Proposed Solution
formatField
will no longer directly pass the arguments to<FieldsEmbed>.embed.fields
, instead it will be stored as a property (array of fields) in the current instance ofFieldsEmbed
and then all formatted fields' functions will be invoked and its output will be passed to<FieldsEmbed>.embed.fields
.This also means that invokingaddField
first is required.This will removeinline
option in favour of requiredaddField
invocation.Name
parameter will be converted to as a field identifier for resolving the desired field and will acceptnumber
type for providing the desired field's index. Number type will be added due to the case of different fields with identical field name.Code ExampleNew syntax
Usage
From:
To:
ps. If you got something on your mind regarding this issue, please do not hesitate to post 🥂
ps2. NICE
The text was updated successfully, but these errors were encountered: