You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
It is almost impossible to use this library in a Jamstack (Next.js + Headless CMS) where things such as dangerouslySetAllPagesToNoIndex are in a customer's control. For example, they start from default dangerouslySetAllPagesToNoIndex: false, then change it to true, then decide to turn it off again - but they cannot (until we rebuild and redeploy Next.js).
Reproduction https://github.com/TheBit/do-not-mutate-things - I described the steps in the readme. It utilizes getServerSideProps just for the sake of simplicity, but we are actually suffering in production which is based on getStaticProps + Strapi + on-demand revalidation (and we reproduced it locally using next dev).
Expected behavior
An obvious thing should happen - it should be possible to change any props passed to next-seo in a running Next.js app without resorting to redeploying new builds.
Describe the bug
It is almost impossible to use this library in a Jamstack (Next.js + Headless CMS) where things such as
dangerouslySetAllPagesToNoIndex
are in a customer's control. For example, they start from defaultdangerouslySetAllPagesToNoIndex: false
, then change it totrue
, then decide to turn it off again - but they cannot (until we rebuild and redeploy Next.js).Reproduction
https://github.com/TheBit/do-not-mutate-things - I described the steps in the readme. It utilizes
getServerSideProps
just for the sake of simplicity, but we are actually suffering in production which is based ongetStaticProps
+ Strapi + on-demand revalidation (and we reproduced it locally usingnext dev
).Expected behavior
An obvious thing should happen - it should be possible to change any props passed to
next-seo
in a running Next.js app without resorting to redeploying new builds.Additional context
Do not mutate stuff :(
https://github.com/garmeeh/next-seo/blob/master/src/meta/buildTags.tsx#L164
The text was updated successfully, but these errors were encountered: