You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve the error handling mechanism in the delta snapshot deletion process here. The proposed changes include:
Continuing with the deletion of the rest of the "deletable" delta snapshots even when an error is encountered, instead of halting the process.
Concatenating all errors encountered during the deletion process using errors.Join(), and returning this concatenated error at the end of the process.
Note: This enhancement is based on the review comment in this #640 (comment).
Motivation (Why is this needed?):
The current implementation stops the garbage collection process of delta snapshots if there's an error with the deletion of a particular snapshot. This could be due to an intermittent error or an issue specific to a single snapshot. The proposed enhancement will ensure that a one-off error doesn't halt the entire process, while still effectively communicating to the function caller that there were errors in deleting delta snapshots.
Approach/Hint to the implement solution (optional):
Modify the deletion process to continue deleting the remaining snapshots even when an error is encountered.
Use the errors.Join() function to concatenate all errors encountered during the process.
The text was updated successfully, but these errors were encountered:
Enhancement (What you would like to be added):
Improve the error handling mechanism in the delta snapshot deletion process here. The proposed changes include:
errors.Join()
, and returning this concatenated error at the end of the process.Motivation (Why is this needed?):
The current implementation stops the garbage collection process of delta snapshots if there's an error with the deletion of a particular snapshot. This could be due to an intermittent error or an issue specific to a single snapshot. The proposed enhancement will ensure that a one-off error doesn't halt the entire process, while still effectively communicating to the function caller that there were errors in deleting delta snapshots.
Approach/Hint to the implement solution (optional):
errors.Join()
function to concatenate all errors encountered during the process.The text was updated successfully, but these errors were encountered: