Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Safe-guard Multi-node etcd cluster members against wrongly mounted volumes #566

Open
ishan16696 opened this issue Dec 29, 2022 · 1 comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/2 Priority (lower number equals higher priority)

Comments

@ishan16696
Copy link
Member

ishan16696 commented Dec 29, 2022

Feature (What you would like to be added):
Right now, I have observed that backup-restore is only writing POD Namespace in safe_guard file as shoot identifier to avoid the issue of wrong volume mount which I feel is not enough in case of multi-node etcd cluster(size>1) as if volume of one etcd cluster member can wrongly mounted to other etcd member of same etcd cluster.
Right now, backup-restore won't able to recognise this case as POD_NAMESPACE of both etcd cluster member is same, so the content of safe_guard file will also be same.

Expected behavior:
etcd backup-restore should not start etcd cluster member if volume of any other etcd cluster member get wrongly mounted.

Approach/Hint to the implement solution (optional):
Along with POD_NAMESPACE, we can also write POD_NAME in safe_guard file.

@ishan16696 ishan16696 added the kind/enhancement Enhancement, improvement, extension label Dec 29, 2022
@ishan16696
Copy link
Member Author

/assign

@abdasgupta abdasgupta added the priority/2 Priority (lower number equals higher priority) label Jan 6, 2023
@ishan16696 ishan16696 removed their assignment Jan 23, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 2, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/2 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants