Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about the procedure of test() #4

Open
jaredwei01 opened this issue Mar 16, 2017 · 2 comments
Open

questions about the procedure of test() #4

jaredwei01 opened this issue Mar 16, 2017 · 2 comments
Assignees
Labels

Comments

@jaredwei01
Copy link

In the method "test" in model.py, it seems that there is a module about training the model using the test data.(from line 236 to 244 ).
I wonder why we should use test golden label here and in line 230, is it used as a validation ?
I'm new in tensorflow, please pardon me if there were errors in my understanding.

@ganeshjawahar ganeshjawahar self-assigned this Mar 24, 2017
@ganeshjawahar
Copy link
Owner

ganeshjawahar commented Mar 24, 2017

Yes, its a bug. Change that portion to this:
loss = self.sess.run([self.loss], feed_dict={ self.input: x, self.time: time, self.target: target, self.context: context})
so that we just seek the loss without doing backprop.

Also there is a bug in data.py. We need to discard input samples from the class label: 'conflict' as suggested by the author.

Send a PR if someone had fixed this successfully.

@jurukode
Copy link

jurukode commented May 9, 2017

Hi @ganeshjawahar,

can you elaborate more about bug in data.py ? What should i change? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants