Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile simulator should follow light/dark mode #4970

Open
2 tasks done
Jacalz opened this issue Jun 24, 2024 · 2 comments
Open
2 tasks done

Mobile simulator should follow light/dark mode #4970

Jacalz opened this issue Jun 24, 2024 · 2 comments
Labels
Driver:mobile Issues relating to the mobile driver specifically enhancement New feature or request mobile-simulator Issues relating to the mobile siumulator.

Comments

@Jacalz
Copy link
Member

Jacalz commented Jun 24, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

The mobile simulator on Linux (maybe MacOS as well if it works similar there?) does not follow the dark theme preference set by the desktop operating system. Given that the apps will adapt to the set theme on Android and iOS, it makes sense to try to follow the theme even when they are simulating a mobile on the desktop. Support for this would allow developers to test their apps with both themes easily.

I suspect that this might apply to Linux phones as well?

Is it possible to construct a solution with the existing API?

Yes. The handling for themes that looks at the XDG dark mode preference is already working in the desktop driver.

Describe the solution you'd like to see.

The code for the desktop driver has code for checking theme preference of light/dark mode. This code can likely be moved into the mobile simulator code.

@Jacalz Jacalz added the mobile-simulator Issues relating to the mobile siumulator. label Jun 24, 2024
@Jacalz
Copy link
Member Author

Jacalz commented Jun 24, 2024

Is this a problem on macOS as well or is the mobile simulator not behaving the same way there? If that is the case then this is likely a Linux specific issue (especially given the note about Linux phones above).

@Jacalz Jacalz added enhancement New feature or request Driver:mobile Issues relating to the mobile driver specifically labels Jun 24, 2024
@andydotxyz
Copy link
Member

This probably applies to all the simulators because they don't use the device specific code, it's just a lightweight window that scales content and simulates the mobile APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Driver:mobile Issues relating to the mobile driver specifically enhancement New feature or request mobile-simulator Issues relating to the mobile siumulator.
Projects
None yet
Development

No branches or pull requests

2 participants