-
Notifications
You must be signed in to change notification settings - Fork 25
implement bracket for resource usage #137
Comments
We indeed need to update Funfix's IO with the latest developments, which includes Your proposal might work for now, but note that:
We would also need a I'm caught up with work on Monix and Cats-Effect at the moment, unfortunately. Plus work and life, I did not have any time left for Funfix. Once Cats-Effect 1.0 and Monix 3.0 will be finally out, I hope to have some time for giving Funfix some needed updates. Until then PRs are welcome in case you'd like to give it a try. |
About 1 and 2, is there a way to enforce this? |
I've seen SO I guess, I just need to make them become uncancellable in the implementation of bracket. |
Don't we have an |
@alexandru Not found one actually.. |
Here's the issue: #138 |
Ah, OK, well, adding such an operation is not very hard to do actually, but
requires some internals juggling.
The interruption capability is basically handled by an internal `
StackedCancelable`.
What we need to do in an `uncancelable` operation is to pass a
`StackedCancelable` that can never be cancelled, as in a fake instance that
does not keep any cancel tokens and that ignores all "cancel" requests.
…On Fri, Aug 3, 2018 at 6:27 PM Stéphane Le Dorze ***@***.***> wrote:
@alexandru <https://github.com/alexandru> Not found one actually..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#137 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAt6RFONwdSCThNH84ia2obqgRRsXyoks5uNGvggaJpZM4Vs6pW>
.
|
I put that quickly in shape.
I've done some (Unit) tests that are passing.. (including cancellation)
I'm wondering if I'm on the right path of if there's a fundamental flaw in it?
The text was updated successfully, but these errors were encountered: