-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: integration for DynamoDB expression syntax #447
Comments
Some related ideas in here if you did see them: #106 |
I did not catch that one. I did a search but I glanced passed it because I assumed it was only scoped to the config of a table not the usage. Can close in favor of the linked issue if you'd prefer to track the |
Could you write examples in relation to the table and the call in a function or sfn? Very similar to what I wrote in #106 though table.updateItem(item, (prev) => ({ ...prev, value: prev.value + 1 })); Could you create a new issue (or re-use this one) with what you want the top level to look like? Personally I think they should be as clean like the event bridge ones. bus
.when(event => event.source === "lambda")
.map(event=>({ name: event.detail.name}))
.pipe()``` |
Can do. Question on the event bus case. Do Wondering because it might change how I think of the ideal API here. |
Dynamo doesn't nessecarily need to be fluent, better if we can keep it as one closure. Limitations in the compilation target and the ability to compose with event bus drove the current design (cannot call two integrations, must filter then transform).
when(event => event.source === "lambda").when(event => event["detail-type"] === "myType")` This is the same as when(event => event.source === "lambda" && event["detail-type"] === "myType")
const lambdaEvent = bus.when(event => event.source === "lambda");
const lambdaFailure = lambdaEvent.when(event => detail.status === "Failure");
const lambdaSuccess = lambdaEvent.when(event => detail.status === "Success");
lambdaEvent .pipe(someFunction);
lambdaFailure .pipe(someFunction);
lambdaSuccess .pipe(someFunction); This would create 3 rules. |
I updated the text with my ideal API. Unfortunately, I only have |
I think we are trying to move to a convention like the typescript repo where we add a keyword section to each issue along with tags. We should probably have issue templates? |
Perhaps this is a stretch, or there is a better way of accomplishing the same task, but having DyanamoDB expression arguments behave as functionless integrations would enable some interesting use cases while being able to benefit from TypeScript checking and syntax.
Desired Behavior
Query
The text was updated successfully, but these errors were encountered: