Function: type inference bug when using FunctionProps

[sam-goodwin]

When using FunctionProps in a Function, type inference will break:

1. when not using props, event is properly inferred

2. when specifying props, event drops to any

The root cause is our definition of FunctionProps, which carries with it the type parameters. They will infer to any because there are no arguments that provide the type, which breaks inference.

export interface FunctionProps<in P = any, O = any, OutP extends P = P>
  extends Omit<
    aws_lambda.FunctionProps,
    "code" | "handler" | "runtime" | "onSuccess" | "onFailure"
  > {
  /**
   * Method which allows runtime computation of AWS client configuration.
   * ```ts
   * new Lambda(clientConfigRetriever('LAMBDA'))
   * ```
   *
   * @param clientName optionally return a different client config based on the {@link ClientName}.
   *
   */
  clientConfigRetriever?: PrewarmProps["clientConfigRetriever"];
  /**
   * The destination for failed invocations.
   *
   * Supports use of Functionless {@link IEventBus} or {@link IFunction}.
   *
   * ```ts
   * const bus = new EventBus<>
   * ```
   *
   * @default - no destination
   */
  onSuccess?: FunctionAsyncOnSuccessDestination<OutP, O>;
  /**
   * The destination for successful invocations.
   *
   * @default - no destination
   */
  onFailure?: FunctionAsyncOnFailureDestination<OutP>;
}

Proposed solution: remove onSuccess and onFailure from the properties and remove all type parameters.