-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream#foldRight1 naming #242
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Stream
foldRight1
methods at https://github.com/functionaljava/functionaljava/blob/master/core/src/main/java/fj/data/Stream.java#L146are named as if the stream must be non-empty but this is not the case.
I think we should either use
A => B
as initial value (to conform with the name, but unsafe) . Or rename to something likefoldRight<Eager|Strict|?>
. Or have both...WDYT ?
The text was updated successfully, but these errors were encountered: