Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language selection is not persistent after page reload #158

Open
saravmajestic opened this issue Sep 22, 2017 · 1 comment
Open

language selection is not persistent after page reload #158

saravmajestic opened this issue Sep 22, 2017 · 1 comment

Comments

@saravmajestic
Copy link

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request

Current behavior

When I select Turkish language using language menu, after page reload, this state is not saved. ie. it loads English content again.

Expected/desired behavior

Page should load with turkish content

Minimal reproduction of the problem with instructions

  • git clone this repo
  • run npm run serve:watch
  • go to localhost
  • select Turkish language from top toolbar right menu
  • Refresh the browser
  • English content loads after refresh instead of Turkish

Environment

  • Angular version: 4.4.1
  • Browser:
  • [x ] Chrome (desktop) version 60
@fulls1z3 fulls1z3 changed the title Language selection is not persistent after page reload language selection is not persistent after page reload Sep 26, 2017
@fulls1z3
Copy link
Owner

@saravmajestic refreshing the browser actually causes loss of the state. As a result, the language gets reset.

I think you pointed out a good issue, added this to our to-do list. There're several possibilities how we can store this language value (ex: cookie, local-storage, or even on a file at server).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants